[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to matc
From: |
Michal Privoznik |
Subject: |
Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema |
Date: |
Fri, 25 Jan 2013 15:07:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130114 Thunderbird/17.0.2 |
On 25.01.2013 14:55, Markus Armbruster wrote:
> Michal Privoznik <address@hidden> writes:
>
>> Currently, we are using 'tray_open' in QMP and 'tray-open' in
>> HMP. However, the QMP documentation was mistakenly using the
>> HMP version.
>
> Could you point me to where we're using "tray_open"?
>
qemu.git $ git grep -npC8 tray_open qapi-schema.json
qapi-schema.json-683-# @type: This field is returned only for compatibility
reasons, it should
qapi-schema.json-684-# not be used (always returns 'unknown')
qapi-schema.json-685-#
qapi-schema.json-686-# @removable: True if the device supports removable media.
qapi-schema.json-687-#
qapi-schema.json-688-# @locked: True if the guest has locked this device from
having its media
qapi-schema.json-689-# removed
qapi-schema.json-690-#
qapi-schema.json:691:# @tray_open: #optional True if the device has a tray and
it is open
qapi-schema.json-692-# (only present if removable is true)
qapi-schema.json-693-#
qapi-schema.json-694-# @dirty: #optional dirty bitmap information (only present
if the dirty
qapi-schema.json-695-# bitmap is enabled)
qapi-schema.json-696-#
qapi-schema.json-697-# @io-status: #optional @BlockDeviceIoStatus. Only present
if the device
qapi-schema.json-698-# supports it and the VM is configured to stop
on errors
qapi-schema.json-699-#
qapi-schema.json-700-# @inserted: #optional @BlockDeviceInfo describing the
device if media is
qapi-schema.json-701-# present
qapi-schema.json-702-#
qapi-schema.json-703-# Since: 0.14.0
qapi-schema.json-704-##
qapi-schema.json-705-{ 'type': 'BlockInfo',
qapi-schema.json-706- 'data': {'device': 'str', 'type': 'str', 'removable':
'bool',
qapi-schema.json-707- 'locked': 'bool', '*inserted':
'BlockDeviceInfo',
qapi-schema.json:708: '*tray_open': 'bool', '*io-status':
'BlockDeviceIoStatus',
qapi-schema.json-709- '*dirty': 'BlockDirtyInfo' } }
qapi-schema.json-710-
qapi-schema.json-711-##
qapi-schema.json-712-# @query-block:
qapi-schema.json-713-#
qapi-schema.json-714-# Get a list of BlockInfo for all virtual block devices.
qapi-schema.json-715-#
qapi-schema.json-716-# Returns: a list of @BlockInfo describing each virtual
block device