Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

[Laszlo Ersek]

On 01/25/13 18:23, Peter Maydell wrote:
> On 25 January 2013 17:20, Laszlo Ersek <address@hidden> wrote:
>> The subscript operator [] is used here in the type name of a compound
>> literal which is probably not what the script intends to catch.
>>
>>   1945  # check for spacing round square brackets; allowed:
>>   1946  #  1. with a type on the left -- int [] a;
>>
>> The code in question was copied from "docs/migration.txt" and seems to
>> match existing practice:
>>
>>   git grep -E '(VMStateField|VMStateSubsection) \[]' \
>>   | wc -l
>>
>>   139
> 
> On the other hand the usage without the space is in the
> majority:
> 
> git grep -E '(VMStateField|VMStateSubsection)\[]' | wc -l
>      218

OK. I propose to take v3 as-is, and in accordance with
<https://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg04116.html>, point
(3), I'll post a patch that eradicates the space from code & docs alike
(those 139  occurrences, plus the two new one in my v3).

(Although I know Stefan doesn't like reformatting patches because they
shadow "real" commits in git blame.)

Thanks
Laszlo