Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

[Alexander Graf]

On 26.01.2013, at 22:46, Andreas Färber wrote:

> Am 26.01.2013 22:31, schrieb Alexander Graf:
>> 
>> On 26.01.2013, at 15:17, Blue Swirl wrote:
>> 
>>> On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf <address@hidden> wrote:
>>>> Cornelia Huck (10):
>>>>     s390: Lowcore mapping helper.
>>>>     s390: Add mapping helper functions.
>>>>     s390: Channel I/O basic definitions.
>>>>     s390: I/O interrupt and machine check injection.
>>>>     s390: Add channel I/O instructions.
>>>>     s390: Virtual channel subsystem support.
>>> 
>>> This would break build on mingw32:
>>> CC    s390x-softmmu/hw/s390x/css.o
>>> /src/qemu/hw/s390x/css.c: In function 'css_interpret_ccw':
>>> /src/qemu/hw/s390x/css.c:226:17: error: 'ERESTART' undeclared (first
>>> use in this function)
>>> /src/qemu/hw/s390x/css.c:226:17: note: each undeclared identifier is
>>> reported only once for each function it appears in
>>> /src/qemu/hw/s390x/css.c:294:20: error: 'EOPNOTSUPP' undeclared (first
>>> use in this function)
>>> /src/qemu/hw/s390x/css.c: In function 'sch_handle_start_func':
>>> /src/qemu/hw/s390x/css.c:350:15: error: 'EOPNOTSUPP' undeclared (first
>>> use in this function)
>>> /src/qemu/hw/s390x/css.c:375:15: error: 'ERESTART' undeclared (first
>>> use in this function)
>> 
>> Stefan, any particular reason I didn't get a buildbot error message about 
>> this yet? :)
> 
> Quite simply there is no mingw builder running against s390-next. ;)
> 
> http://buildbot.b1-systems.de/qemu/buildslaves
> 
> Just like nobody is setting up any builder against qom-cpu... :(
> I believe only Daniel can set them up, ping.

IMHO builders should build all trees against all targets, not just particular 
ones.


Alex