Re: [Qemu-devel] [PATCH v2] target-arm: add Faraday ARMv5TE processors support

[Kuo-Jung Su]

2013/1/25 Peter Maydell <address@hidden>

On 25 January 2013 07:18, Kuo-Jung Su <address@hidden> wrote:
> From: Kuo-Jung Su <address@hidden>
>
> Faraday processors are a series of ARMv4/ARMv5TE clone.
>
> * ARMv4 series (FA526, FA626).
>
>     All of them are now out-of-date, so I have no plan for them.
>
> * ARMv5TE series (FA606TE, FA626TE, FA616TE, FA726TE)
>
>     All the single core RISC listed above are included in this patch.
>     And there are two Faraday CP15 extensions (AUX and I/D-Scratchpad)
>     have been implemented as a read/write value without any extra actions.

I'm going to need pointers to the CPU documentation to be able
to review this patch, though it looks mostly ok.

One point: you've added new CPU state fields so you must add
save and restore code for them in target-arm/machine.c
(and increment CPU_SAVE_VERSION in target-arm/cpu.h.)

thanks
-- PMM

I'm afraid that I don't have enough permission to release full version of the cpu datasheets.

However I've prepared some partial version with only CP15 and MCU descriptions at my

Google Drive:

https://docs.google.com/folder/d/0BwfiewvSmUgAalh5TkxyZWtlWEE/edit

And thanks for the comments about target-arm/machine.c and target-arm/cpu.h.

I don't even know these things shall be updated until you reminded me.

--
Best wishes,
Kuo-Jung Su