[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform sup
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support |
Date: |
Mon, 28 Jan 2013 08:22:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 25.01.2013 10:07, schrieb Andreas Färber:
> Am 25.01.2013 09:19, schrieb Kuo-Jung Su:
>> hw/a360.c | 271 +++++++++++++++++++++++
>> hw/a369.c | 581
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>> hw/arm/Makefile.objs | 6 +
>> hw/faraday.h | 21 ++
>> 4 files changed, 879 insertions(+)
>> create mode 100644 hw/a360.c
>> create mode 100644 hw/a369.c
>> create mode 100644 hw/faraday.h
>>
>> diff --git a/hw/a360.c b/hw/a360.c
>> new file mode 100644
>> index 0000000..cb0a588
>> --- /dev/null
>> +++ b/hw/a360.c
>> @@ -0,0 +1,271 @@
>> +/*
>> + * Faraday A360 Evalution Board
>> + *
>> + * Copyright (c) 2012 Faraday Technology
>> + * Written by Dante Su <address@hidden>
>> + *
>> + * This code is licensed under GNU GPL v2.
>
> Can you please license this and any other files as "v2 or (at your
> option) any later version"? Cf. http://wiki.qemu.org/Relicensing
>
> Also, there is work underway to move target-specific files to the
> subdirectories of hw/, i.e. suggest the new ARM machine should go to
> hw/arm/faraday_a360.c as hw/ is terribly crowded today and a360 is
> pretty generic.
The same applies to the machine names "a360" and "a369" - I feel they
are too ambiguous, given that there is an AllWinner A20 SoC for
instance. Can you consider renaming to something less ambiguous like
"faraday-a360" or so?
Andreas
> For devices it depends on whether they are tightly
> coupled to the ARM SoC or reusable in any target (x86 etc.).
>
> Regards,
> Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 03/18] hw: add QEMU model for Faraday AHB DMA, (continued)
- [Qemu-devel] [PATCH 03/18] hw: add QEMU model for Faraday AHB DMA, Dante, 2013/01/18
- [Qemu-devel] [PATCH 04/18] hw: add QEMU model for Faraday 1Gbps Ethernet MAC, Dante, 2013/01/18
- [Qemu-devel] [PATCH 05/18] hw: add QEMU model for Faraday 10/100Mbps Ethernet MAC, Dante, 2013/01/18
- Re: [Qemu-devel] [PATCH 01/18] hw: add Faraday a369 SoC platform support, Blue Swirl, 2013/01/19
- [Qemu-devel] [PATCH v2 00/20] Add Faraday A36x SoC platform support, Kuo-Jung Su, 2013/01/25
- [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support, Kuo-Jung Su, 2013/01/25
- Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support, Blue Swirl, 2013/01/25
- Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support, Igor Mitsyanko, 2013/01/31
[Qemu-devel] [PATCH v2 03/20] arm: add Faraday FTAPBBRG020 APB DMA support, Kuo-Jung Su, 2013/01/25
[Qemu-devel] [PATCH v2 02/20] arm: add Faraday FUSBH200 EHCI controller, Kuo-Jung Su, 2013/01/25