Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

[Richard Henderson]

On 01/27/2013 05:32 AM, Andreas Färber wrote:
> Make LOG_DISAS() arguments compile-testable even if disabled.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>   target-alpha/translate.c |   12 ++++++------
>   1 Datei geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-)

Acked-by: Richard Henderson <address@hidden>

> +#define LOG_DISAS(...) G_STMT_START \
> +    if (ALPHA_DEBUG_DISAS) { \
> +        qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__); \
> +    } \
> +    G_STMT_END

I see zero advantage to using G_STMT_START/END over the
shorter and significantly more obvious direct use of do/while.

We just zapped useless gtype typedefs.  Do we have to add
yet another useless glib thing?


r~