qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image cre


From: Othmar Pasteka
Subject: Re: [Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image creation
Date: Tue, 29 Jan 2013 00:18:15 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Hello,


On Mon, Jan 28, 2013 at 11:56:47PM +0100, Othmar Pasteka wrote:
> @@ -1453,6 +1454,7 @@ static int vmdk_create(const char *filename, 
> QEMUOptionParameter *options)
>      const char *desc_extent_line;
>      char parent_desc_line[BUF_SIZE] = "";
>      uint32_t parent_cid = 0xffffffff;
> +uint32_t number_heads = 16;
>      const char desc_template[] =
>          "# Disk DescriptorFile\n"
>          "version=1\n"

right after sending the patch I discovered this indentation bug.
I check with checkpatch before sending it, but it didn't complain
and it slipped on my side. Should I resend the patch with that fixed?

regards,
Othmar




reply via email to

[Prev in Thread] Current Thread [Next in Thread]