[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variab
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables |
Date: |
Tue, 29 Jan 2013 09:18:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Hi,
Am 29.01.2013 07:42, schrieb Kuo-Jung Su:
> Thanks for reminding me of the usb_ehci_pci_initfn.
>
> But I have a stupid question.......
>
> Which one do the upcoming path v2 looks like ?
>
> 1. It contains only the diff to usb_ehci_pci_initfn, for example:
>
> [Qemu-devel][PATCH v2 0/1] usb-ehci: add Faraday FUSBH200 support
> [Qemu-devel][PATCH v2 1/1] usb-ehci: update usb_ehci_pci_initfn to
> use variable version of portsc
>
> 2. It contains the entired change logs, for example:
>
> [Qemu-devel][PATCH v2 0/3] usb-ehci: add Faraday FUSBH200 support
> [Qemu-devel][PATCH v2 1/3] usb-ehci: replace PORTSC macros with
> variables ..
> [Qemu-devel][PATCH v2 2/3] usb-ehci: add Faraday FUSBH200 support
> [Qemu-devel][PATCH v2 3/3] usb-ehci: update usb_ehci_pci_initfn ...
Neither. You should send a v2 consisting of two patches, with 1/2
containing the requested fix, so that at no point in your patch series
anything breaks.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg