Re: [Qemu-devel] 答复: [PATCH qom-cpu for-1. 4] target-unicore32: Rename CPU subtypes

[Andreas Färber]

嗨,

Am 29.01.2013 10:25, schrieb Guan Xuetao:
>> -----邮件原件-----
>> 发件人: Andreas Färber [mailto:address@hidden
>> 发送时间: Monday, January 28, 2013 23:47
>> 收件人: address@hidden
>> 抄送: Guan Xuetao
>> 主题: Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-unicore32: Rename
>> CPU subtypes
>>
>> Am 27.01.2013 23:50, schrieb Andreas Färber:
>>> In the initial conversion of CPU models to QOM types, model names were
>>> mapped 1:1 to type names. As a side effect this gained us a type
>>> "any", which is now a device.
>>>
>>> To avoid "-device any" silliness and to pave the way for compiling
>>> multiple targets into one executable, adopt a <name>-<arch>-cpu scheme.
>>>
>>> No functional changes for -cpu arguments.
>>>
>>> Signed-off-by: Andreas Färber <address@hidden>
>>
>> Patch breaks linux-user due to forgetting to update cpu_model_str.
>> I'll double-check the other targets.
>>
> After this patch was applied, I saw the following error when running:
>       qemu: hardware error: Unable to find CPU definition

As indicated above, this patch has a bug, sorry. I will send a v2.
Forking in linux-user will be broken (cpu_copy()), everything else
should work though, no?

Can you please test qemu.git master and confirm that it is not broken
without this patch?

I do not have any unicore32 image for testing. I therefore tested
"./unicore32-softmmu/qemu-system-unicore32 -cpu ?" (which did not seem
implemented) and "./unicore32-softmmu/qemu-system-unicore32" without
parameters, which ran into a kernel_filename assertion IIRC.
Can you upload a test image and static linux-user binaries somewhere? Or
provide me with instructions how to build a toolchain and kernel?

Thanks,
Andreas

P.S. FYI a hw/uc32/ directory has been created in the meantime. If you
still wish to move your puv3 files out of hw/, please feel invited to
send a patch.

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg