[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: Fix signedness of loads in MIPS16
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: Fix signedness of loads in MIPS16 RESTOREs |
|
Date: |
Fri, 1 Feb 2013 00:00:31 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Jan 20, 2013 at 07:28:48PM +0000, Richard Sandiford wrote:
> Make RESTORE use sign-extending rather than zero-extending loads.
>
> Signed-off-by: Richard Sandiford <address@hidden>
> ---
> target-mips/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 47528d7..623edd0 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -9409,7 +9409,7 @@ static void gen_mips16_restore (DisasContext *ctx,
>
> #define DECR_AND_LOAD(reg) do { \
> tcg_gen_subi_tl(t0, t0, 4); \
> - tcg_gen_qemu_ld32u(t1, t0, ctx->mem_idx); \
> + tcg_gen_qemu_ld32s(t1, t0, ctx->mem_idx); \
> gen_store_gpr(t1, reg); \
> } while (0)
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net