Re: [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X

[Anthony Liguori]

Please ignore the 1/2 in the subject...  a bit past beer time and I got
a little sloppy sending this patch.

Regards,

Anthony Liguori

Anthony Liguori <address@hidden> writes:

> The multiqueue patch series broke -netdev tap,fd=X which manifests
> as libvirt not being able to start a guest.  This was because it
> passed NULL for the netdev name which results in an anonymous netdev
> device regardless of what the user specified.
>
> Cc: Jason Wang <address@hidden>
> Cc: Bruce Rogers <address@hidden>
> Reported-by: Bruce Rogers <address@hidden>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  net/tap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tap.c b/net/tap.c
> index 1bf7609..48c254e 100644
> --- a/net/tap.c
> +++ b/net/tap.c
> @@ -711,7 +711,7 @@ int net_init_tap(const NetClientOptions *opts, const char 
> *name,
>  
>          vnet_hdr = tap_probe_vnet_hdr(fd);
>  
> -        if (net_init_tap_one(tap, peer, "tap", NULL, NULL,
> +        if (net_init_tap_one(tap, peer, "tap", name, NULL,
>                               script, downscript,
>                               vhostfdname, vnet_hdr, fd)) {
>              return -1;
> -- 
> 1.8.0