[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts |
Date: |
Mon, 04 Feb 2013 17:17:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 |
On 02/04/13 16:07, Stefan Hajnoczi wrote:
> slirp uses OOB because it implements TCP. I don't think we can drop it.
I considered slirp for that reason, and I did grep the tree for OOB and
saw some hits. I didn't track it down but I thought slirp would use
lower level sockets (SOCK_RAW?) for the TCP implementation. Ie. it would
provide OOB but not depend on it (because OOB doesn't make sense at the
IP level; the urgent pointer is in the TCP header). Anyway it's not
important.
> Yes, it's an interesting feature of pollfds_poll(). It does not clobber
> revents. This means you can apply additional *_poll()-style functions
> before calling pollfds_poll(). I thought this was neat but I guess we
> can drop it.
Ah I didn't realize that. I think a comment should be enough, should you
respin it.
> Thanks for the review. If I need to respin I'll address comments.
It's more clear now, thanks!
Laszlo
[Qemu-devel] [PATCH v3 06/10] iohandler: switch to GPollFD, Stefan Hajnoczi, 2013/02/04
[Qemu-devel] [PATCH v3 05/10] slirp: switch to GPollFD, Stefan Hajnoczi, 2013/02/04
[Qemu-devel] [PATCH v3 04/10] slirp: slirp/slirp.c coding style cleanup, Stefan Hajnoczi, 2013/02/04