[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 09/12] qemu-char: Redo chardev "memory"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 09/12] qemu-char: Redo chardev "memory" size configuration |
Date: |
Tue, 05 Feb 2013 15:33:46 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> New device, has never been released, so we can still improve things
> without worrying about compatibility:
>
> * Rename parameter from maxcapacity to size (simple words are good for
> you).
>
> * Clearly mark the parameter as optional in documentation.
>
> * Support suffixed size arguments like "size=64K",
>
> * Fix chardev-add to report errors to current monitor, not stderr.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-char.c | 11 +++++------
> qemu-options.hx | 11 ++++-------
> 2 files changed, 9 insertions(+), 13 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH for-1.4 01/12] qmp: Fix design bug and read beyond buffer in memchar-write, (continued)
Re: [Qemu-devel] [PATCH for-1.4 01/12] qmp: Fix design bug and read beyond buffer in memchar-write, Luiz Capitulino, 2013/02/06
[Qemu-devel] [PATCH for-1.4 08/12] qemu-char: Drop undocumented chardev "memory" compatibility syntax, Markus Armbruster, 2013/02/05
[Qemu-devel] [PATCH for-1.4 09/12] qemu-char: Redo chardev "memory" size configuration, Markus Armbruster, 2013/02/05
- Re: [Qemu-devel] [PATCH for-1.4 09/12] qemu-char: Redo chardev "memory" size configuration,
Eric Blake <=
[Qemu-devel] [PATCH for-1.4 12/12] QAPI QMP HMP: Fix and improve memchar-read/-write docs, Markus Armbruster, 2013/02/05
[Qemu-devel] [PATCH for-1.4 11/12] qmp: Use generic errors in memchar-read, memchar-write, Markus Armbruster, 2013/02/05
[Qemu-devel] [PATCH for-1.4 10/12] qemu-char: General chardev "memory" code cleanup, Markus Armbruster, 2013/02/05
Re: [Qemu-devel] [PATCH for-1.4 00/12] Fix memchar-read/-write before API gets released, Luiz Capitulino, 2013/02/06
Re: [Qemu-devel] [PATCH for-1.4 00/12] Fix memchar-read/-write before API gets released, Anthony Liguori, 2013/02/06