[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V2 7/7] qmp: Add block-dedup-control.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V2 7/7] qmp: Add block-dedup-control. |
Date: |
Thu, 07 Feb 2013 10:44:31 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/06/2013 05:32 AM, Benoît Canet wrote:
> ---
> blockdev.c | 20 ++++++++++++++++++++
> qapi-schema.json | 19 +++++++++++++++++++
> qmp-commands.hx | 25 +++++++++++++++++++++++++
> 3 files changed, 64 insertions(+)
>
> +++ b/qapi-schema.json
> @@ -812,6 +812,25 @@
> ##
> { 'enum': 'DedupStatus', 'data': [ 'stopped', 'starting', 'started',
> 'stopping' ] }
> +##
> +# @block-dedup-control:
> +#
> +# This command pause the deduplication on a device that supports it.
s/pause/controls/, or copy your wording from the .hx file.
> +#
> +# @device: the name of the device to control the deduplication for
> +# @enable: true to start, false to stop
> +#
> +# Returns: nothing on success
> +# If @device is not a valid block device, DeviceNotFound
> +# GenericError if @device is not deduplicated
Most API in this file don't bother calling out GenericError; it is
implicit that pretty much any function is allowed to fail with a
GenericError and that the text of the error message would hopefully
explain why.
> +SQMP
> +block-dedup-control
> +------------
> +
> +Start or stop the deduplication on a device that support it.
s/support/supports/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V2 0/7] QCOW2 asynchronous deduplication, Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 2/7] qcow2: Add code to deduplicate cluster flagged with QCOW_OFLAG_TO_DEDUP., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 6/7] qcow2: Make dedup status persists., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 5/7] qcow2: Add qcow2_dedup_control., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 7/7] qmp: Add block-dedup-control., Benoît Canet, 2013/02/06
- Re: [Qemu-devel] [RFC V2 7/7] qmp: Add block-dedup-control.,
Eric Blake <=
- [Qemu-devel] [RFC V2 4/7] block: Add bdrv_dedup_control to start and stop deduplication., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 3/7] block: Add bdrv_has_dedup., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 1/7] block: Add BlockDriver function prototype to pause and resume deduplication., Benoît Canet, 2013/02/06