Re: [Qemu-devel] [PATCH qom-cpu-next v2 0/1] QOM'ify CRIS CPU

[Edgar E. Iglesias]

On Thu, Feb 07, 2013 at 06:04:40PM +0100, Andreas Färber wrote:
> Hi Edgar,
> 
> This patch takes a second attempt at introducing CPU subclasses for cris.
> 
> In v1 I had used a declarative CRISCPUInfo-based class initialization;
> this v2 now proposes a TypeInfo/class_init based approach, removing the field
> duplication and preparing to manually extend the crisv32 class_init later.
> 
> It is based on my qom-cpu-next queue, which made changes to cpu_cris_init().
> With this patch on top, cpu_cris_init() becomes fully QOM-compliant.
> Tested using -cpu ? and -M axis-dev88 test image. Please ack.
> 
> Available for testing from:
> git://github.com/afaerber/qemu-cpu.git qom-cpu-cris-classes.v2
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-cris-classes.v2
> 
> Regards,
> Andreas
> 
> Cc: Edgar E. Iglesias <address@hidden>

Acked-by: Edgar E. Iglesias <address@hidden>

> 
> v1 -> v2:
> * Redone using class_init.
> * Added checks against non-CPU and abstract types.
> 
> qom-cpu-others patch:
> https://github.com/afaerber/qemu-cpu/commit/ca8e1e7b501ce0c2dc391d60b9b4c1651eac72cf
> 
> Andreas Färber (1):
>   target-cris: Introduce CRISCPU subclasses
> 
>  target-cris/cpu-qom.h   |    3 +
>  target-cris/cpu.c       |  153 
> ++++++++++++++++++++++++++++++++++++++++++++++-
>  target-cris/translate.c |   48 ---------------
>  3 Dateien geändert, 155 Zeilen hinzugefügt(+), 49 Zeilen entfernt(-)
> 
> -- 
> 1.7.10.4
>