Re: [Qemu-devel] [PATCH] pc-bios: build OpenBIOS if possible

[Michael Tokarev]

09.02.2013 23:01, Blue Swirl wrote:
> Check if xsltproc and Sparc32, Sparc64 and PPC compilers
> are available. If found, rebuild OpenBIOS ROMs from submodule.
>
> Signed-off-by: Blue Swirl <address@hidden>
> ---
> A patch to OpenBIOS is also needed to support out of tree build,
> just sent to the list.
[]
> +# OpenBIOS needs xsltproc, and Sparc32, Sparc64 and PPC cross compilers
> +if has xsltproc; then
> +    if has_crossgcc "sparc" -a has_crossgcc "sparc64" -a \
> +        \( has_crossgcc "powerpc" -o  has_crossgcc "ppc" \); then
> +        roms="$roms openbios"
> +    fi
> +fi

Do we need to be able to turn it off?  Or maybe we should just
stop doing this by default (since binaries are already present
in the tarball), but instead suggest user to run `make -C roms'
if [s]he needs/wants these roms to be rebuilt?

I guess this is not a question for this patch but a more general
question.

I dislike rebuilding stuff this way, in particular because current
system may have some outdated (or too new) compiler for that stuff
to produce somehow broken binary, because this way, the resulting
blobs differs from ones in the tarball and comparing in attempt to
find what has changed shows these and makes some noize, -- stuff
like that.


> +++ b/pc-bios/openbios/Makefile
> +config-timestamp: $(SRC_PATH)/roms/openbios/config/scripts/switch-arch
> +       mkdir build || true

That's what `mkdir -p' if for.

Thanks,

/mjt