Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

[Peter Maydell]

On 10 February 2013 22:12, Hervé Poussineau <address@hidden> wrote:
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val)
>          break;
>      case WIN_PACKETCMD:
>          /* overlapping commands not supported */
> -        if (s->feature & 0x02)
> +        if (s->feature & 0x02) {
> +            qemu_log_mask(LOG_UNIMP, "ide: overlapping command not 
> supported");

Messages for qemu_log_mask() need to supply the trailing \n.

Otherwise looks good.

-- PMM