[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log()
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log() |
Date: |
Mon, 11 Feb 2013 16:41:24 +0000 |
The set_cpu_log() function in cpus.c is a fairly simple wrapper
which is only called from one location. Just inline the code
into vl.c, since there is no need to indirect it via cpus.c
and the handling of the error case is more appropriate to vl.c.
Signed-off-by: Peter Maydell <address@hidden>
---
cpus.c | 12 ------------
include/sysemu/cpus.h | 1 -
vl.c | 9 ++++++++-
3 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/cpus.c b/cpus.c
index 24e6aff..c4b021d 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1175,18 +1175,6 @@ void set_numa_modes(void)
}
}
-void set_cpu_log(const char *optarg)
-{
- int mask;
-
- mask = qemu_str_to_log_mask(optarg);
- if (!mask) {
- qemu_print_log_usage(stdout);
- exit(1);
- }
- qemu_set_log(mask);
-}
-
void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg)
{
/* XXX: implement xxx_cpu_list for targets that still miss it */
diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h
index 60e44bb..6502488 100644
--- a/include/sysemu/cpus.h
+++ b/include/sysemu/cpus.h
@@ -24,7 +24,6 @@ extern int smp_threads;
#endif
void set_numa_modes(void);
-void set_cpu_log(const char *optarg);
void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg);
#endif
diff --git a/vl.c b/vl.c
index 06e5369..2e204d0 100644
--- a/vl.c
+++ b/vl.c
@@ -3860,10 +3860,17 @@ int main(int argc, char **argv, char **envp)
* location or level of logging.
*/
if (log_mask) {
+ int mask;
if (log_file) {
qemu_set_log_filename(log_file);
}
- set_cpu_log(log_mask);
+
+ mask = qemu_str_to_log_mask(log_mask);
+ if (!mask) {
+ qemu_print_log_usage(stdout);
+ exit(1);
+ }
+ qemu_set_log(mask);
}
if (!trace_backend_init(trace_events, trace_file)) {
--
1.7.9.5
- [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename, (continued)
- [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories", Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 6/6] qemu-log: Rename CPULogItem, cpu_log_items to QEMULogItem, qemu_log_items, Peter Maydell, 2013/02/11
- [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log(),
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Richard Henderson, 2013/02/11
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Stefan Hajnoczi, 2013/02/12
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Blue Swirl, 2013/02/13
- Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names, Blue Swirl, 2013/02/16