Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

[Alexander Graf]

Am 12.02.2013 um 18:50 schrieb Andreas Färber <address@hidden>:

> Am 12.02.2013 18:33, schrieb Peter Maydell:
>> Switch the default for qemu_log logging output from "/tmp/qemu.log"
>> to stderr. This is an incompatible change in some sense, but logging
>> is mostly used for debugging purposes so it shouldn't affect production
>> use. The previous behaviour can be obtained by adding "-D /tmp/qemu.log"
>> to the command line.
>> 
>> This change requires us to:
>> * update all the documentation/help text
>> * make linux-user and bsd-user defer to qemu-log for the default
>>   logging destination rather than overriding it themselves
>> * ensure that all logfile closing is done via qemu_log_close()
>>   and that that function doesn't close stderr
>> as well as the obvious change to the behaviour of do_qemu_set_log()
>> when no logfile name has been specified.
>> 
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> Stefan suggested that qemu_log should default to stderr, and I
>> agree that it makes more sense than a random file in /tmp/.
>> As noted in the commit message, this is technically an incompatible
>> change.
> 
> I don't think this change is okay, it should be limited to the softmmus.
> Having random debug output appear on stderr may well break linux-user
> test suites or use cases.

But only when you pass in -d, no?

Alex

> 
> Regards,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg