[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pseries: Add cleanup hook for PAPR virtual LAN
|
From: |
Anthony Liguori |
|
Subject: |
Re: [Qemu-devel] [PATCH] pseries: Add cleanup hook for PAPR virtual LAN device |
|
Date: |
Wed, 13 Feb 2013 11:42:45 -0600 |
|
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Andreas Färber <address@hidden> writes:
> Am 11.02.2013 05:59, schrieb David Gibson:
>> Currently the spapr-vlan device does not supply a cleanup call for its
>> NetClientInfo structure. With current qemu versions, that leads to a SEGV
>> on exit, when net_cleanup() attempts to call the cleanup handlers on all
>> net clients.
>>
>> Signed-off-by: David Gibson <address@hidden>
>
> Tested-by: Andreas Färber <address@hidden>
>
> On Anthony's request I posted a patch that adds back the if surrounding
> the cleanup callback, fixing also the other affected nics.
Since this cleanup hook doesn't do anything useful and we need to apply
Andreas' patch anyway, I don't think there's any benefit to apply this one.
Regards,
Anthony Liguori
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg