[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 4/5] cadence_gem: Dont reset rx desc pointer on r
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH v1 4/5] cadence_gem: Dont reset rx desc pointer on rx_en |
Date: |
Fri, 15 Feb 2013 14:51:39 +1000 |
This doesnt happen in the real hardware. The Zynq TRM explicitly states that
this bit has no effect on the rx descriptor pointer ("The receive queue
pointer register is unaffected").
Signed-off-by: Peter Crosthwaite <address@hidden>
---
hw/cadence_gem.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/hw/cadence_gem.c b/hw/cadence_gem.c
index a1ac069..61f1801 100644
--- a/hw/cadence_gem.c
+++ b/hw/cadence_gem.c
@@ -1083,10 +1083,6 @@ static void gem_write(void *opaque, hwaddr offset,
uint64_t val,
/* Reset to start of Q when transmit disabled. */
s->tx_desc_addr = s->regs[GEM_TXQBASE];
}
- if (!(val & GEM_NWCTRL_RXENA)) {
- /* Reset to start of Q when receive disabled. */
- s->rx_desc_addr = s->regs[GEM_RXQBASE];
- }
if (val & GEM_NWCTRL_RXENA) {
qemu_flush_queued_packets(qemu_get_queue(s->nic));
}
--
1.7.0.4
- [Qemu-devel] [PATCH v1 0/5] Zynq GEM updates, Peter Crosthwaite, 2013/02/14
- [Qemu-devel] [PATCH v1 1/5] cadence_gem: Flush queued packets, Peter Crosthwaite, 2013/02/14
- [Qemu-devel] [PATCH v1 2/5] cadence_gem: factor out can_rx() logic replication, Peter Crosthwaite, 2013/02/14
- [Qemu-devel] [PATCH v1 3/5] cadence_gem: fix interrupt events, Peter Crosthwaite, 2013/02/14
- [Qemu-devel] [PATCH v1 4/5] cadence_gem: Dont reset rx desc pointer on rx_en,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v1 5/5] cadence_gem: Add debug msgs for rx desc movement, Peter Crosthwaite, 2013/02/14
- Re: [Qemu-devel] [PATCH v1 0/5] Zynq GEM updates, Peter Crosthwaite, 2013/02/20
- Re: [Qemu-devel] [PATCH v1 0/5] Zynq GEM updates, Peter Maydell, 2013/02/28