Re: [Qemu-devel] [PATCH] iscsi: add iscsi_truncate support

[Kevin Wolf]

On Fri, Feb 15, 2013 at 12:54:51PM +0100, Paolo Bonzini wrote:
> Il 15/02/2013 12:18, Peter Lieven ha scritto:
> >>>
> >>> +    task = iscsi_readcapacity16_task(iscsilun->iscsi, iscsilun->lun,
> >>> +                                 iscsi_readcapacity16_cb, &itask);
> >>
> >> You can use iscsi_readcapacity16_sync.  In fact, you probably should
> >> extract code from iscsi_open and reuse it here.
> > 
> > Thats not possible afaik. Mixing sync and async commands in libiscsi is
> > a very bad thing. It will leed to nested event loops.
> 
> Ah, I thought qmp_block_resize did a bdrv_drain_all before calling
> bdrv_truncate.
> 
> Maybe it should.  Kevin, what do you think?

Probably. bdrv_truncate() invalidates the bdrv_check_request() result for
in-flight requests, so there better be none.

Kevin