[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qemu-log: default to stderr for logging outp
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] qemu-log: default to stderr for logging output |
Date: |
Mon, 18 Feb 2013 14:45:36 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 18, 2013 at 11:51:26AM +0000, Peter Maydell wrote:
> Switch the default for qemu_log logging output from "/tmp/qemu.log"
> to stderr. This is an incompatible change in some sense, but logging
> is mostly used for debugging purposes so it shouldn't affect production
> use. The previous behaviour can be obtained by adding "-D /tmp/qemu.log"
> to the command line.
>
> This change requires us to:
> * update all the documentation/help text (we take the opportunity
> to smooth out minor inconsistencies between the phrasing in
> linux-user/bsd-user/system help messages)
> * make linux-user and bsd-user defer to qemu-log for the default
> logging destination rather than overriding it themselves
> * ensure that all logfile closing is done via qemu_log_close()
> and that that function doesn't close stderr
> as well as the obvious change to the behaviour of do_qemu_set_log()
> when no logfile name has been specified.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Changes since v1:
> * dropped an unnecessary "if (log_file)" check from bsd-user
> * standardised the phrasing of the -d and -D help text for
> all of bsd-user, linux-user and system mode
>
> NB: if this is applied before the linux-user patch
> http://patchwork.ozlabs.org/patch/220481/
> then the column formatting in linux-user's --help output will
> be slightly misaligned.
>
>
> bsd-user/main.c | 18 ++++++++----------
> hmp-commands.hx | 4 ++--
> include/qemu/log.h | 8 ++++++--
> linux-user/main.c | 16 +++++-----------
> qemu-doc.texi | 8 ++++----
> qemu-log.c | 29 +++++++++++------------------
> qemu-options.hx | 10 +++++-----
> tcg/tci/README | 2 +-
> 8 files changed, 42 insertions(+), 53 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>