[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 1/3] iov: Factor out hexdumper
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v9 1/3] iov: Factor out hexdumper |
|
Date: |
Tue, 19 Feb 2013 09:35:33 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 |
Hi,
> I ran git blame on it and its actually Gerds code. Gerd you want
> co-authorship and the (c) of this hexdump.c?
Yes.
And don't break iov_hexdump() behavior please. I suggest to just
iov_to_buf() into a temporary buffer, then pass that to a single hexdump
call. When calling hexdump for each iovec element the buffer offsets
printed are wrong for all but the first iovec element.
cheers,
Gerd