[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/41] qemu-file: make qemu_fflush and qemu_file
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH 24/41] qemu-file: make qemu_fflush and qemu_file_set_error private again |
Date: |
Tue, 19 Feb 2013 17:44:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/15/2013 07:46 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/migration/qemu-file.h | 2 --
> savevm.c | 4 ++--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h
> index 5e0c287..46fc11d 100644
> --- a/include/migration/qemu-file.h
> +++ b/include/migration/qemu-file.h
> @@ -82,7 +82,6 @@ QEMUFile *qemu_popen_cmd(const char *command, const char
> *mode);
> int qemu_get_fd(QEMUFile *f);
> int qemu_fclose(QEMUFile *f);
> int64_t qemu_ftell(QEMUFile *f);
> -void qemu_fflush(QEMUFile *f);
> void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, int size);
> void qemu_put_byte(QEMUFile *f, int v);
>
> @@ -114,7 +113,6 @@ int qemu_file_rate_limit(QEMUFile *f);
> int64_t qemu_file_set_rate_limit(QEMUFile *f, int64_t new_rate);
> int64_t qemu_file_get_rate_limit(QEMUFile *f);
> int qemu_file_get_error(QEMUFile *f);
> -void qemu_file_set_error(QEMUFile *f, int ret);
>
> static inline void qemu_put_be64s(QEMUFile *f, const uint64_t *pv)
> {
> diff --git a/savevm.c b/savevm.c
> index ce10295..fef2ab9 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -443,7 +443,7 @@ int qemu_file_get_error(QEMUFile *f)
> return f->last_error;
> }
>
> -void qemu_file_set_error(QEMUFile *f, int ret)
> +static void qemu_file_set_error(QEMUFile *f, int ret)
> {
> if (f->last_error == 0) {
> f->last_error = ret;
> @@ -453,7 +453,7 @@ void qemu_file_set_error(QEMUFile *f, int ret)
> /** Flushes QEMUFile buffer
> *
> */
> -void qemu_fflush(QEMUFile *f)
> +static void qemu_fflush(QEMUFile *f)
> {
> int ret = 0;
>
>
Reviewed-by: Orit Wasserman <address@hidden>
- [Qemu-devel] [PATCH 35/41] migration: use QEMUFile for writing outgoing migration data, (continued)
- [Qemu-devel] [PATCH 35/41] migration: use QEMUFile for writing outgoing migration data, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 34/41] migration: use QEMUFile for migration channel lifetime, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 29/41] migration: merge qemu_popen_cmd with qemu_popen, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 24/41] qemu-file: make qemu_fflush and qemu_file_set_error private again, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 28/41] migration: use qemu_file_rate_limit consistently, Paolo Bonzini, 2013/02/15
- Re: [Qemu-devel] [PATCH 00/41] Migration cleanups and latency improvements, Chegu Vinod, 2013/02/19