[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 14/14] hmp: show snapshots on single block de
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V6 14/14] hmp: show snapshots on single block device |
Date: |
Tue, 19 Feb 2013 13:51:15 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/18/2013 07:09 AM, Wenchao Xia wrote:
> This patch added the support of showing internal snapshots on a
> single block device in hmp layer, by simply change parameter in
s/change/changing a/
> calling of qmp funtion.
s/funtion/function/
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> hmp.c | 7 ++++++-
> monitor.c | 6 +++---
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index d29787f..834ee42 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -633,8 +633,10 @@ void hmp_info_snapshots(Monitor *mon, const QDict *qdict)
> {
> Error *err = NULL;
> SnapshotInfoList *list;
> + const char *device = qdict_get_try_str(qdict, "device");
> + bool has_device = device ? true : false;
The prevailing style appears to be:
bool has_device = !!device;
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V6 06/14] block: add image info query function bdrv_query_image_info(), (continued)
- [Qemu-devel] [PATCH V6 04/14] block: move collect_snapshots() and collect_image_info() to block.c, Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 12/14] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 09/14] block: move bdrv_snapshot_find() to block.c, Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 08/14] qmp: add interface query-images., Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 14/14] hmp: show snapshots on single block device, Wenchao Xia, 2013/02/18
- Re: [Qemu-devel] [PATCH V6 14/14] hmp: show snapshots on single block device,
Eric Blake <=
- [Qemu-devel] [PATCH V6 10/14] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 05/14] block: add snapshot info query function bdrv_query_snapshot_infolist(), Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 11/14] qmp: add interface query-snapshots, Wenchao Xia, 2013/02/18
[Qemu-devel] [PATCH V6 13/14] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/02/18