qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] doc: document -netdev hubport


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] doc: document -netdev hubport
Date: Thu, 21 Feb 2013 09:26:05 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Feb 20, 2013 at 05:21:24PM +0100, Laszlo Ersek wrote:
> On 02/20/13 11:03, Stefan Hajnoczi wrote:
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > ---
> >  qemu-options.hx | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 4bc9c85..c77c43e 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -1404,7 +1404,8 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
> >  #ifdef CONFIG_VDE
> >      "vde|"
> >  #endif
> > -    "socket],id=str[,option][,option][,...]\n", QEMU_ARCH_ALL)
> > +    "socket|"
> > +    "hubport],id=str[,option][,option][,...]\n", QEMU_ARCH_ALL)
> >  STEXI
> >  @item -net nic[,address@hidden,address@hidden,address@hidden 
> > [,address@hidden,address@hidden,address@hidden
> >  @findex -net
> > @@ -1726,6 +1727,14 @@ vde_switch -F -sock /tmp/myswitch
> >  qemu-system-i386 linux.img -net nic -net vde,sock=/tmp/myswitch
> >  @end example
> >  
> > address@hidden -netdev hubport,address@hidden,address@hidden
> > +
> > +Create a hub port on QEMU "vlan" @var{hubid}.  This syntax is an 
> > alterative to
> 
> Typo:
> - alterative
> - alternative
> 
> > +the -net @option{vlan} argument and can be used to connect a NIC specified 
> > with
> > +-device to a QEMU "vlan".
> 
> Can we say
> 
>     [...] with -device address@hidden to a QEMU "vlan"
> 
> or is the netdev= optarg obvious? (It's just the generic dev -> netdev
> reference.)

Good points, thanks.  I'll send a v2.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]