|
From: | Juan Quintela |
Subject: | Re: [Qemu-devel] [PATCH 04/41] migration: push qemu_savevm_state_cancel out of qemu_savevm_state_* |
Date: | Thu, 21 Feb 2013 18:17:47 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote: > This is useful, because it lets us keep the cancellation callbacks > inside the big lock while pushing the others out. > > Signed-off-by: Paolo Bonzini <address@hidden> Reviewed-by: Juan Quintela <address@hidden> If we need to rebase: > ret = qemu_file_get_error(f); > - if (ret != 0) { > - qemu_savevm_state_cancel(); > - } > - > return ret; return qemu_file_get_error(f); looks better than: ret = qemu_file_get_error(f); return ret; IMHO O:-) > - > } > > /* > @@ -1677,9 +1671,6 @@ int qemu_savevm_state_iterate(QEMUFile *f) > return ret; > } > ret = qemu_file_get_error(f); > - if (ret != 0) { > - qemu_savevm_state_cancel(); > - } > return ret; Same here
[Prev in Thread] | Current Thread | [Next in Thread] |