Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

[Andreas Färber]

Am 22.02.2013 19:22, schrieb Peter Maydell:
> On 22 February 2013 18:20, Andreas Färber <address@hidden> wrote:
>> Am 22.02.2013 19:10, schrieb Peter Maydell:
>>> From: Andreas Färber <address@hidden>
>>> index c0f6c6d..252bd14 100644
>>> --- a/target-alpha/cpu-qom.h
>>> +++ b/target-alpha/cpu-qom.h
>>> @@ -72,5 +72,6 @@ static inline AlphaCPU *alpha_env_get_cpu(CPUAlphaState 
>>> *env)
>>>
>>>  #define ENV_GET_CPU(e) CPU(alpha_env_get_cpu(e))
>>>
>>> +#define ENV_OFFSET offsetof(AlphaCPU, env)
>>>
>>>  #endif
>> [snip]
>>
>> Compared to my rebased copy of this patch on qom-cpu-10 yours is
>> dropping a white line per target. I've intentionally used two lines
>> spacing for grouping and a line between definitions. Matter of taste.
> 
> Yeah, I deliberately dropped a bunch of what I felt were
> extraneous blank lines :-)

I've applied it to qom-cpu since it conflicts with my additions of
vmstate_..._cpu fields and ..._do_interrupt() functions.

https://github.com/afaerber/qemu-cpu/commits/qom-cpu

But I will remind you of you messing with my coding style next time you
ask me to redo any ifs to your liking. May Markus be my witness. Either
we respect each other's style in cross-target refactorings or we don't.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg