[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] target-arm: Fix sbc_CC carry
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] target-arm: Fix sbc_CC carry |
|
Date: |
Mon, 25 Feb 2013 19:48:16 +0000 |
On 25 February 2013 19:41, Richard Henderson <address@hidden> wrote:
> While T0+~T1+CF = T0-T1+CF-1 is true for the low 32-bits,
> it does not produce the correct carry-out to bit 33. Do
> exactly what the manual says.
>
> Using the ~T1 makes the add and subtract code paths nearly
> identical, so have sbc_CC use adc_CC.
>
> Cc: Peter Maydell <address@hidden>
> Reported-by: Laurent Desnogues <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- [Qemu-devel] [PATCH v3 0/3] Fix two carry problems in add2 patchset, Richard Henderson, 2013/02/25
- [Qemu-devel] [PATCH v3 1/3] arm/translate.c: Fix adc_CC/sbc_CC implementation, Richard Henderson, 2013/02/25
- [Qemu-devel] [PATCH v3 2/3] target-arm: Fix sbc_CC carry, Richard Henderson, 2013/02/25
- Re: [Qemu-devel] [PATCH v3 2/3] target-arm: Fix sbc_CC carry,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 3/3] target-ppc: Fix SUBFE carry, Richard Henderson, 2013/02/25
- Re: [Qemu-devel] [PATCH v3 0/3] Fix two carry problems in add2 patchset, Peter Maydell, 2013/02/25
- Re: [Qemu-devel] [PATCH v3 0/3] Fix two carry problems in add2 patchset, Anthony Liguori, 2013/02/26