[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to bl
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c |
Date: |
Mon, 4 Mar 2013 14:02:22 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 01, 2013 at 09:51:53AM +0800, Wenchao Xia wrote: > δΊ 2013-2-28
0:22, Kevin Wolf ει:
> >Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:
> >>Wenchao Xia <address@hidden> writes:
> >>
> >>>Signed-off-by: Wenchao Xia <address@hidden>
> >>>Reviewed-by: Eric Blake <address@hidden>
> >>>---
> >>> block.c | 24 ++++++++++++++++++++++++
> >>> include/block/block.h | 2 ++
> >>> savevm.c | 22 ----------------------
> >>> 3 files changed, 26 insertions(+), 22 deletions(-)
> >>
> >>Perhaps savevm.c isn't the best home for snapshot stuff, but I don't
> >>like it in block.c any better. block.c is already unwieldy, and I'd
> >>like us to try limiting it to core block stuff.
> >>
> >>Kevin, Stefan, any ideas?
> >
> >Take some more snapshot related functions from block.c and move them to
> >block/snapshot.c?
> >
> >Kevin
> >
> Hi, Stefan
> Do you also agree about adding new file block/snapshot.c?
Yes, I agree.
Stefan