[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] migration: Improve QMP documentation
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] migration: Improve QMP documentation |
|
Date: |
Wed, 06 Mar 2013 11:34:06 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/06/2013 11:26 AM, Juan Quintela wrote:
> v2:
> Add Markus sugestions:
If you keep this in the commit message, then
s/sugestions/suggestions/
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
But it's better to stick patch changelog (your v2 comment) here, after
the ---, since it is nice for reviewers but useless information in the
git logs.
> + - "duplicate": number of pages filled entirely with the same
> + byte (json-int)
> + These are sent over the wire much more efficiently.
TAB damage.
Contents look fine, so once the commit message and whitespace is fixed,
feel free to add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature