Re: [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c

[Eric Blake]

On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>   This patch also fix small code style error reported by check script.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  block/snapshot.c         |   23 +++++++++++++++++++++++
>  include/block/snapshot.h |    9 +++++++++
>  savevm.c                 |   23 +----------------------
>  3 files changed, 33 insertions(+), 22 deletions(-)
> 

> +++ b/include/block/snapshot.h
> @@ -1,4 +1,13 @@
>  #ifndef SNAPSHOT_H
>  #define SNAPSHOT_H
>  
> +#include "qemu-common.h"
> +/*
> + * block.h is needed for QEMUSnapshotInfo, it can be removed when define is
> + * moved here.
> + */
> +#include "block.h"

Why not move QEMUSnapshotInfo here as part of this patch, and/or reorder
the series to do the code motion of that type before you move the function?

That said, this looks like an accurate code motion patch.  But see my
comments earlier in the series about merging this with 1/20.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature