[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now mandatory o
|
From: |
Riku Voipio |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now mandatory on all targets |
|
Date: |
Mon, 11 Mar 2013 17:00:41 +0200 |
>>> #if defined(TARGET_ARM) || defined(TARGET_M68K) ||
>>> defined(TARGET_UNICORE32)
>>> /* Extra fields for semihosted binaries. */
>>> - uint32_t stack_base;
>>> uint32_t heap_base;
>>> uint32_t heap_limit;
>>> #endif
>>> + uint32_t stack_base;
>> Shouldn't this be abi_ulong instead of uint32_t?
> Ping...
> Yes it's more than a year old, but if Aarch64 support with semihosting
> ever comes to life :)
You are right, but we need to change the other variables as well, and
the tswap32 code in semihosting code while at it? I think the change
is probable better done in the patches that actually add aarch64
semihosting support to qemu.
Riku