[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] find_next_bit optimizations
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [RFC] find_next_bit optimizations |
Date: |
Mon, 11 Mar 2013 16:41:06 +0100 |
Am 11.03.2013 um 16:37 schrieb Peter Maydell <address@hidden>:
> On 11 March 2013 15:24, Peter Lieven <address@hidden> wrote:
>> + unsigned long d0,d1,d2,d3;
>
> These commas should have spaces after them. Also, since
> the variables are only used inside the scope of your
> newly added while loop:
>
>> - while (size & ~(BITS_PER_LONG-1)) {
>> + while (size >= 4*BITS_PER_LONG) {
>
> it would be better to declare them here.
can you verify if this does not make difference in the generated object code?
in buffer_is_zero() its outside the loop.
thanks
peter
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, (continued)
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, ronnie sahlberg, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
- [Qemu-devel] [PATCH] bitops: unroll while loop in find_next_bit()., Peter Lieven, 2013/03/12
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Maydell, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Maydell, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations,
Peter Lieven <=
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
Re: [Qemu-devel] [RFC] find_next_bit optimizations, Stefan Hajnoczi, 2013/03/12