Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

[Wenchao Xia]

于 2013-3-12 1:49, Eric Blake 写道:
> On 03/11/2013 05:23 AM, Wenchao Xia wrote:
> >    This patch adds block/snapshot.c and then moves the function
> > there. It also fixes small code style errors reported by check script.
> >
> > Signed-off-by: Wenchao Xia <address@hidden>
> > ---
> >   block/Makefile.objs      |    1 +
> >   block/snapshot.c         |   37 +++++++++++++++++++++++++++++++++++++
> >   include/block/snapshot.h |   26 ++++++++++++++++++++++++++
> >   savevm.c                 |   23 +----------------------
> >   4 files changed, 65 insertions(+), 22 deletions(-)
> >   create mode 100644 block/snapshot.c
> >   create mode 100644 include/block/snapshot.h
>
> > +++ b/block/snapshot.c
> > @@ -0,0 +1,37 @@
> > +/*
> > + * Snapshot related functions.
> > + *
> > + * Copyright IBM, Corp. 2013
>
> Technically, since you are moving code from savevm.c, you should also
> preserve the copyright on that moved code:
>
>   * Copyright (c) 2003-2008 Fabrice Bellard
>
> > + *
> > + * Authors:
> > + *  Wenchao Xia   <address@hidden>
> > + *
> > + * This work is licensed under the terms of the GNU LGPL, version 2 or later.
>
> Furthermore, the code you are moving was under BSD license, so by moving
> the code, you have changed its license to something more restrictive.
> Personally, I like LGPL better than BSD, but as I'm not the copyright
> holder of the original code, and neither are you, I'm not sure that
> either of us is qualified to make that change.  Therefore, I'm unwilling
> to add my Reviewed-by, even though the code motion itself is correct,
> without a maintainer chiming in on whether your licensing is appropriate
> or needs an adjustment.
  Oops, Since it belongs to block layer I hope it can be LGPL2. Do you
know how to contact Fabrice Bellard to ask for a change?

--
Best Regards

Wenchao Xia