qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no request


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight
Date: Wed, 13 Mar 2013 11:15:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3

Il 13/03/2013 10:31, Kevin Wolf ha scritto:
> Isn't the real problem that I/O requests for _this_specific_ iscsi BDS
> must not be in flight? So what you reall need is bdrv_drain(iscsi_bs)?
> 
> If I understand the code correctly, this boils down to:
> 
>     while (iscsi_process_flush(iscsilun)) {
>         qemu_aio_wait();
>     }

Yes, but this function is not doing a truncate at all.  It is simply
updating the cached result of bdrv_getlength.  I think it makes sense
that this function (which should not be truncate, but something else)
expects to be called with no pending requests.  It shouldn't be its task
to drain them.

I'll look at fixing this as mentioned in the earlier thread.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]