[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/7] spice-qemu-char: Fix name parameter issues afte
From: |
Hans de Goede |
Subject: |
[Qemu-devel] [PATCH 3/7] spice-qemu-char: Fix name parameter issues after qapi-ifying |
Date: |
Wed, 13 Mar 2013 14:59:43 +0100 |
The strings passed in through the qapi calls are dynamic memory, since
we want to have them stick around longer then just the call to
qemu_chr_open_spice_* we need to strdup them.
Signed-off-by: Hans de Goede <address@hidden>
---
spice-qemu-char.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 0c92ca8..a94f76b 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -185,6 +185,11 @@ static void spice_chr_close(struct CharDriverState *chr)
printf("%s\n", __func__);
vmc_unregister_interface(s);
QLIST_REMOVE(s, next);
+
+ g_free((char *)s->sin.subtype);
+#if SPICE_SERVER_VERSION >= 0x000c02
+ g_free((char *)s->sin.portname);
+#endif
g_free(s);
}
@@ -226,7 +231,7 @@ static CharDriverState *chr_open(const char *subtype)
s = g_malloc0(sizeof(SpiceCharDriver));
s->chr = chr;
s->active = false;
- s->sin.subtype = subtype;
+ s->sin.subtype = g_strdup(subtype);
chr->opaque = s;
chr->chr_write = spice_chr_write;
chr->chr_close = spice_chr_close;
@@ -284,7 +289,7 @@ CharDriverState *qemu_chr_open_spice_port(const char *name)
chr = chr_open("port");
s = chr->opaque;
- s->sin.portname = name;
+ s->sin.portname = g_strdup(name);
return chr;
}
--
1.8.1.4
- [Qemu-devel] [PATCH 0/7] Spice / usb-redir chardev flowcontrol patches, Hans de Goede, 2013/03/13
- [Qemu-devel] [PATCH 1/7] virtio-console: Also throttle when less was written then requested, Hans de Goede, 2013/03/13
- [Qemu-devel] [PATCH 2/7] virtio-console: Remove any pending watches on close, Hans de Goede, 2013/03/13
- [Qemu-devel] [PATCH 4/7] spice-qemu-char: Remove dead debugging code, Hans de Goede, 2013/03/13
- [Qemu-devel] [PATCH 3/7] spice-qemu-char: Fix name parameter issues after qapi-ifying,
Hans de Goede <=
- [Qemu-devel] [PATCH 6/7] spice-qemu-char.c: Remove intermediate buffer, Hans de Goede, 2013/03/13
- [Qemu-devel] [PATCH 5/7] spice-qemu-char: Add watch support, Hans de Goede, 2013/03/13
- [Qemu-devel] [PATCH 7/7] usb-redir: Add flow control support, Hans de Goede, 2013/03/13