Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts

[Fabien Chouteau]

On 03/14/2013 01:34 PM, Markus Armbruster wrote:
> Fabien Chouteau <address@hidden> writes:
> 
>> On 03/14/2013 09:44 AM, Markus Armbruster wrote:
>>> Fabien Chouteau <address@hidden> writes:
>>>
>>>> We introduce a new command line option. It's a generic option to
>>>> customize the gdb server:
>>>>
>>>> -gdb-opts [attached=on|off]
>>>>
>>>> The only parameter for now is "attached".
>>>>
>>>> Signed-off-by: Fabien Chouteau <address@hidden>
>>>
>>> --gdb-opts complements existing --gdb.  You need to use both for full
>>> control.
>>>
>>> I figure you do this because you can't extend --gdb, as its argument is
>>> in legacy character device syntax, not QemuOpts.
>>>
>>
>> That's right, maybe we can do some string manipulations to handle this case.
>>
>> -gdb tcp::1234,attached=off
>>
>> find ',attached={on|off}' and remove it from the string.
>
> That way is madness :)

Come on, you've seen worse ;)

>>> We had similar cases before, and solved them differently: create a more
>>> general option, then make the old one sugar for the new one.
>>>
>>> For instance, --monitor and --qmp are sugar for --mon.  Desugaring code
>>> is in monitor_parse().
>>>
>>
>> Something like:
>>
>> -chardev socket,id=gdb1,host=localhost,port=1234,server,nowait,nodelay
>> -gdb-remote chardev=gdb1,attached=off
>>
>> You still need two options for full control.
> 
> Yes, but following precedence is good.  Our command line is inconsistent
> enough as it is.  Just my two cents.
> 

Fair enough, lets forget about the option this is too much work. I'll
just tweak the sources on our branch.

Regards,

-- 
Fabien Chouteau