On 03/15/2013 09:12 PM, Peter Maydell wrote:
On 10 March 2013 13:47, Igor Mitsyanko <address@hidden> wrote:
hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for dynamically
allocated buffer migration, this was causing memory corruption.
Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag set) instead.
Not sure what to do with vmstate version for his devices, should I bump it? Migration
was never working for them anyway.
Only tested hw/sd.c, by saving/loading a snapshot of VM while it was playing videofile
from SD card.
Cc'ing Juan in case he wants to comment on the vmstate changes.
-- PMM
Thanks, Peter. Also cc'ing Andrzej Zaborowski using a (correct) address from MAINTAINERS, because the one in hw/onenand.c is not working.