Re: [Qemu-devel] [PATCH v8 00/24] hw/arm: add Faraday A369 SoC platform support

[Kuo-Jung Su]

2013/3/15 Peter Maydell <address@hidden>:
> On 15 March 2013 13:15, Kuo-Jung Su <address@hidden> wrote:
>>  default-configs/arm-softmmu.mak |    1 +
>>  hw/Makefile.objs                |    2 +
>>  hw/arm/Makefile.objs            |   21 ++
>>  hw/arm/faraday.h                |   61 ++++
>>  hw/arm/faraday_a369.c           |  174 ++++++++++
>>  hw/arm/faraday_a369_kpd.c       |  231 +++++++++++++
>>  hw/arm/faraday_a369_scu.c       |  182 ++++++++++
>>  hw/arm/faraday_a369_soc.c       |  342 +++++++++++++++++++
>>  hw/arm/ftahbc020.c              |  202 +++++++++++
>>  hw/arm/ftapbbrg020.c            |  468 ++++++++++++++++++++++++++
>>  hw/arm/ftapbbrg020.h            |   44 +++
>>  hw/arm/ftddrii030.c             |  183 ++++++++++
>>  hw/arm/ftdmac020.c              |  595 ++++++++++++++++++++++++++++++++
>>  hw/arm/ftdmac020.h              |  107 ++++++
>>  hw/arm/ftgmac100.c              |  708 
>> +++++++++++++++++++++++++++++++++++++++
>>  hw/arm/ftgmac100.h              |  239 +++++++++++++
>>  hw/arm/fti2c010.c               |  212 ++++++++++++
>>  hw/arm/fti2c010.h               |   71 ++++
>>  hw/arm/ftintc020.c              |  302 +++++++++++++++++
>>  hw/arm/ftintc020.h              |   57 ++++
>>  hw/arm/ftkbc010.h               |   44 +++
>>  hw/arm/ftlcdc200.c              |  510 ++++++++++++++++++++++++++++
>>  hw/arm/ftlcdc200.h              |  112 +++++++
>>  hw/arm/ftlcdc200_template.h     |  439 ++++++++++++++++++++++++
>>  hw/arm/ftmac110.c               |  661 ++++++++++++++++++++++++++++++++++++
>>  hw/arm/ftmac110.h               |  168 ++++++++++
>>  hw/arm/ftnandc021.c             |  516 ++++++++++++++++++++++++++++
>>  hw/arm/ftnandc021.h             |   84 +++++
>>  hw/arm/ftpwmtmr010.c            |  258 ++++++++++++++
>>  hw/arm/ftpwmtmr010.h            |   31 ++
>>  hw/arm/ftrtc011.c               |  383 +++++++++++++++++++++
>>  hw/arm/ftrtc011.h               |   53 +++
>>  hw/arm/ftsdc010.c               |  354 ++++++++++++++++++++
>>  hw/arm/ftsdc010.h               |   90 +++++
>>  hw/arm/ftspi020.c               |  337 +++++++++++++++++++
>>  hw/arm/ftspi020.h               |   81 +++++
>>  hw/arm/ftssp010.c               |  494 +++++++++++++++++++++++++++
>>  hw/arm/ftssp010.h               |   98 ++++++
>>  hw/arm/fttmr010.c               |  445 ++++++++++++++++++++++++
>>  hw/arm/fttmr010.h               |   41 +++
>>  hw/arm/fttsc010.c               |  260 ++++++++++++++
>>  hw/arm/fttsc010.h               |   39 +++
>>  hw/arm/ftwdt010.c               |  209 ++++++++++++
>>  hw/arm/ftwdt010.h               |   35 ++
>
> I don't have time to do a full review right now, but a lot
> of these files are in the wrong place. If it looks like a
> device it doesn't belong in hw/arm (top level board models
> and things that directly reference the CPU only).
>
> -- PMM

Got it, thanks.

-- 
Best wishes,
Kuo-Jung Su