Re: [Qemu-devel] [PATCH][RFC 03/14] qdev: remove redundant abort()

[Andreas Färber]

Am 13.03.2013 09:01, schrieb liguang:
> Signed-off-by: liguang <address@hidden>
> ---
>  hw/qdev.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/qdev.c b/hw/qdev.c
> index 689cd54..2bed9d8 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -116,11 +116,10 @@ DeviceState *qdev_create(BusState *bus, const char 
> *name)
>          if (bus) {
>              error_report("Unknown device '%s' for bus '%s'", name,
>                           object_get_typename(OBJECT(bus)));
> -            abort();
>          } else {
>              error_report("Unknown device '%s' for default sysbus", name);
> -            abort();
>          }
> +        abort();
>      }
>  
>      return dev;

Reviewed-by: Andreas Färber <address@hidden>

However this being a fatal abort, it doesn't really matter too much.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg