[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support |
Date: |
Tue, 19 Mar 2013 13:40:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.3 |
On 03/14/13 17:36, Hans de Goede wrote:
> + if (!dev->watch) {
> + dev->watch = qemu_chr_fe_add_watch(dev->cs, G_IO_OUT,
> + usbredir_write_unblocked,
> dev);
> + }
> + if (r < 0)
> + r = 0;
> + }
> + return r;
=== checkpatch complains ===
WARNING: braces {} are necessary for all arms of this statement
#48: FILE: hw/usb/redirect.c:290:
+ if (r < 0)
[...]
total: 0 errors, 1 warnings, 65 lines checked
cheers,
Gerd
- [Qemu-devel] [PATCH 4/8] spice-qemu-char: Add watch support, (continued)
- [Qemu-devel] [PATCH 6/8] spice-qemu-char: Move spice_chr_close down, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support, Hans de Goede, 2013/03/14
- Re: [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 5/8] spice-qemu-char: Remove intermediate buffer, Hans de Goede, 2013/03/14
- Re: [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2, Amit Shah, 2013/03/18