[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 07/12] Store the data to send also in iovec
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC 07/12] Store the data to send also in iovec |
Date: |
Thu, 21 Mar 2013 14:00:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 21/03/2013 13:50, Orit Wasserman ha scritto:
> On 03/21/2013 01:14 PM, Michael S. Tsirkin wrote:
>> On Thu, Mar 21, 2013 at 01:10:40PM +0200, Orit Wasserman wrote:
>>> On 03/21/2013 11:56 AM, Paolo Bonzini wrote:
>>>> Il 21/03/2013 10:09, Orit Wasserman ha scritto:
>>>>> All data is still copied into the static buffer.
>>>>>
>>>>> Signed-off-by: Orit Wasserman <address@hidden>
>>>>> ---
>>>>> savevm.c | 13 +++++++++++--
>>>>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/savevm.c b/savevm.c
>>>>> index ec64533..d5834ca 100644
>>>>> --- a/savevm.c
>>>>> +++ b/savevm.c
>>>>> @@ -114,6 +114,7 @@ void qemu_announce_self(void)
>>>>> /* savevm/loadvm support */
>>>>>
>>>>> #define IO_BUF_SIZE 32768
>>>>> +#define MAX_IOV_SIZE 64
>>>>
>>>> You could use IOV_MAX, or min(IOV_MAX, 64).
>
> Paolo, are you ok with leaving it MIN(IOV_MAX, 64) at the moment?
Of course! (When I use "..." it means "I don't expect you to do that..."
:)).
Paolo
- Re: [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function, (continued)
[Qemu-devel] [RFC 08/12] Use writev ops instead of put_buffer ops, Orit Wasserman, 2013/03/21
[Qemu-devel] [RFC 09/12] More optimized qemu_put_be64/32/16, Orit Wasserman, 2013/03/21
[Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy, Orit Wasserman, 2013/03/21
[Qemu-devel] [RFC 11/12] Use qemu_put_buffer_no_copy for guest memory pages, Orit Wasserman, 2013/03/21