qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 18/26] hw/usb/dev-smartcard-reader.c: copy atr's


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH 18/26] hw/usb/dev-smartcard-reader.c: copy atr's protocol to ccid's parameters (adds todo's)
Date: Fri, 22 Mar 2013 15:23:15 +0100

Hi,


On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy <address@hidden> wrote:
> +    if (atr_protocol_num == 0) {
> +        DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T0 parameters"
> +                " setting\n", __func__);
> +        t0->bmFindexDindex = 0;
> +        t0->bmTCCKST0 = 0;
> +        t0->bGuardTimeT0 = 0;
> +        t0->bWaitingIntegerT0 = 0;
> +        t0->bClockStop = 0;
> +    } else {
> +        if (atr_protocol_num != 1) {
> +            DPRINTF(s, D_WARN, "%s: error: unsupported ATR protocol %d\n",
> +                    __func__, atr_protocol_num);
> +        } else {
> +            DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T1 parameters"
> +                    " setting\n", __func__);
> +            t1->bmFindexDindex = 0;
> +            t1->bmTCCKST1 = 0;
> +            t1->bGuardTimeT1 = 0;
> +            t1->bWaitingIntegerT1 = 0;
> +            t1->bClockStop = 0;
> +            t1->bIFSC = 0;
> +            t1->bNadValue = 0;
> +        }
> +    }

Those blocks could be at the same indentation level, or perhaps use a switch?

Is it sensible to warn in all cases?

-- 
Marc-André Lureau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]