Re: [Qemu-devel] [PATCH 06/14] nbd: Keep hostname and port separate

[Kevin Wolf]

Am 22.03.2013 um 23:46 hat Paolo Bonzini geschrieben:
> Il 22/03/2013 18:41, Kevin Wolf ha scritto:
> > +        QemuOpts *opts = qemu_opts_create_nofail(&socket_optslist);
> > +
> > +        qemu_opt_set(opts, "host", s->inet_addr->host);
> > +        qemu_opt_set(opts, "port", s->inet_addr->port);
> > +        if (s->inet_addr->has_to) {
> > +            qemu_opt_set_number(opts, "to", s->inet_addr->to);
> > +        }
> > +        if (s->inet_addr->has_ipv4) {
> > +            qemu_opt_set_number(opts, "ipv4", s->inet_addr->ipv4);
> > +        }
> > +        if (s->inet_addr->has_ipv6) {
> > +            qemu_opt_set_number(opts, "ipv6", s->inet_addr->ipv6);
> > +        }
> > +
> > +        sock = tcp_socket_outgoing_opts(opts);
> 
> Sorry for the late review... You're basically reinventing socket_connect
> here.  Would like to clean it up or shall I do it?

It's probably best if you change whatever you like to have changed.
FWIW, this specific code doesn't exist any more at the end of the
series.

Kevin