Re: [Qemu-devel] [PATCH v2 04/12] savevm: add error parameter to qemu_savevm_state_iterate()

[Eric Blake]

On 03/22/2013 07:16 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
>  include/sysemu/sysemu.h | 2 +-
>  migration.c             | 2 +-
>  savevm.c                | 5 ++---
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>


> @@ -1811,9 +1811,8 @@ static int qemu_savevm_state(QEMUFile *f)
>      qemu_savevm_state_begin(f, &params, NULL);
>      qemu_mutex_lock_iothread();
>  
> -
>      while (qemu_file_get_error(f) == 0) {

Spurious whitespace change will go away when you fix 3/12 to not
introduce it in the first place.

> -        if (qemu_savevm_state_iterate(f) > 0) {
> +        if (qemu_savevm_state_iterate(f, NULL) > 0) {
>              break;
>          }
>      }
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature