[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/12] savevm: icrease the IO_BUF_SIZE to imp
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/12] savevm: icrease the IO_BUF_SIZE to improve the speed of savevm |
Date: |
Tue, 26 Mar 2013 16:05:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/22/2013 07:16 AM, Pavel Hrdina wrote:
s/icrease/increase/ in the subject
Some benchmark numbers in the commit message justifying your change
would be nice.
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
> savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/savevm.c b/savevm.c
> index 3e3d5f8..532c1be 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -112,7 +112,7 @@ void qemu_announce_self(void)
> /***********************************************************/
> /* savevm/loadvm support */
>
> -#define IO_BUF_SIZE 32768
> +#define IO_BUF_SIZE 1 * 1024 * 1024
Improperly parenthesized; needs to be:
#define IO_BUF_SIZE (1 * 1024 * 1024)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 07/12] qapi: Convert savevm, (continued)
- [Qemu-devel] [PATCH v2 06/12] savevm: add error parameter to qemu_savevm_state(), Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 08/12] qemu-img: introduce qemu_img_handle_error, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 10/12] savevm: update return value from qemu_savevm_state, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 09/12] block: update return value from bdrv_snapshot_create, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 12/12] savevm: icrease the IO_BUF_SIZE to improve the speed of savevm, Pavel Hrdina, 2013/03/22
- Re: [Qemu-devel] [PATCH v2 12/12] savevm: icrease the IO_BUF_SIZE to improve the speed of savevm,
Eric Blake <=
- [Qemu-devel] [PATCH v2 11/12] vm-snapshot-save: add force parameter, Pavel Hrdina, 2013/03/22