Re: [Qemu-devel] [PATCH V10 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list()

[Eric Blake]

On 03/22/2013 08:19 AM, Wenchao Xia wrote:
>   This patch adds function bdrv_query_snapshot_info_list(), which will
> retrieve snapshot info of an image in qmp object format. The implementation
> is based on the code moved from qemu-img.c with modification to fit more
> for qmp based block layer API.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  block/qapi.c         |   52 +++++++++++++++++++++++++++++++++++++------------
>  include/block/qapi.h |    4 ++-
>  qemu-img.c           |    4 ++-
>  3 files changed, 45 insertions(+), 15 deletions(-)

> +        default:
> +            error_setg(errp, "Can't list snapshots of device '%s': %s",
> +                       dev, strerror(-sn_count));

This works (hence I didn't notice it before), but you might want to use:

error_setg_errno(errp, -sn_count,
                 "Can't list snapshots of device '%s'", dev);

Either way, you can keep my

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature