qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 05/20] tcg-arm: Handle constant arguments to


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3 05/20] tcg-arm: Handle constant arguments to add2/sub2
Date: Thu, 28 Mar 2013 09:16:22 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4

On 03/28/2013 09:09 AM, Laurent Desnogues wrote:
>> I think it actually makes everything a lot cleaner myself.  Especially given
>> the previous definition that required runtime checks for TST et al.
> 
> I also find this cleaner.  OTOH I understand that Peter finds it
> odd given that other operations (such as ADD) can optionally
> set flags.

Well of course they can.  Which is exactly why I'm doing all this, because I
can include that bit in the add2/sub2 expansion below.  It's just that the
comparison insns *require* the S bit set, which is what is going on in this 
enum.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]